From 1068376829a8ef11a87c5e096c9f60365ae251d6 Mon Sep 17 00:00:00 2001
From: Snorre <snorre@altschul.dk>
Date: Sat, 5 Apr 2025 04:31:12 +0200
Subject: [PATCH] why is the trigger called 'select_button'

---
 resources/player.tscn |  6 +++---
 scripts/XRHand.cs     | 34 ++++++++++++++++++----------------
 2 files changed, 21 insertions(+), 19 deletions(-)

diff --git a/resources/player.tscn b/resources/player.tscn
index 718078a..6be2dfb 100644
--- a/resources/player.tscn
+++ b/resources/player.tscn
@@ -39,6 +39,6 @@ shape = SubResource("SphereShape3D_iyx0m")
 
 [node name="XRCamera3D" type="XRCamera3D" parent="."]
 
-[connection signal="button_pressed" from="LeftHand" to="." method="OnPress"]
-[connection signal="input_float_changed" from="LeftHand" to="." method="OnFloat"]
-[connection signal="profile_changed" from="LeftHand" to="LeftHand" method="OnProfileChanged"]
+[connection signal="button_pressed" from="LeftHand" to="LeftHand" method="OnPress"]
+[connection signal="button_released" from="LeftHand" to="LeftHand" method="OnRelease"]
+[connection signal="input_float_changed" from="LeftHand" to="LeftHand" method="OnFloat"]
diff --git a/scripts/XRHand.cs b/scripts/XRHand.cs
index c142741..ae2797a 100644
--- a/scripts/XRHand.cs
+++ b/scripts/XRHand.cs
@@ -14,6 +14,16 @@ public partial class XRHand : XRController3D
     public override void _Process(double delta)
     {
         if ((bool)GetInput("trigger_click"))
+        {
+        }
+        else if (joints.Count > 0)
+        {
+        }
+    }
+
+    public void OnPress(string name)
+    {
+        if (name == "select_button")
         {
             var query = new PhysicsShapeQueryParameters3D();
             var sphere = new SphereShape3D();
@@ -47,7 +57,11 @@ public partial class XRHand : XRController3D
                 AddChild(joint);
             }
         }
-        else if (joints.Count > 0)
+    }
+
+    public void OnRelease(string name)
+    {
+        if (name == "select_button")
         {
             foreach (var joint in joints)
                 joint.QueueFree();
@@ -55,22 +69,10 @@ public partial class XRHand : XRController3D
         }
     }
 
-    public void OnProfileChange(string name)
-    {
-        GD.Print("Profile changed to:");
-        GD.Print(name);
-    }
-
-    public void OnPress(string name)
-    {
-        GD.Print("Button pressed:");
-        GD.Print(name);
-    }
-
     public void OnFloat(string name, float value)
     {
-        GD.Print("Float input:");
-        GD.Print(name);
-        GD.Print(value);
+        // GD.Print("Float input:");
+        // GD.Print(name);
+        // GD.Print(value);
     }
 }